Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fixing flaky test #549

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Try fixing flaky test #549

merged 1 commit into from
Jan 30, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 30, 2024

  • Add more info on test failure during certificate test cleanup
  • Fix an error occuring when deleting the CR: controllers would still try to update the CR status despite the CR being deleted

@jotak
Try fixing flaky test
4377959 
- Add more info on test failure during certificate test cleanup
- Fix an error occuring when deleting the CR: controllers would still
  try to update the CR status despite the CR being deleted
jpinsonneau
jpinsonneau approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 seems to fix it for now on my side. Thanks

@openshift-ci openshift-ci bot added the lgtm label Jan 30, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 30, 2024

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 4377959 link false /test e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jotak
Copy link
Member Author

jotak commented Jan 30, 2024

/retest

@jotak
Copy link
Member Author

jotak commented Jan 30, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5958936 into netobserv:main Jan 30, 2024
8 of 9 checks passed
jotak added a commit that referenced this pull request Feb 2, 2024
@jotak
Try fixing flaky test (#549)
cbde5f8 
- Add more info on test failure during certificate test cleanup
- Fix an error occuring when deleting the CR: controllers would still
  try to update the CR status despite the CR being deleted
@jotak jotak deleted the try-fix-flaky branch February 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@jpinsonneau jpinsonneau jpinsonneau approved these changes

Assignees

@OlivierCazade OlivierCazade

@jpinsonneau jpinsonneau

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jotak @OlivierCazade @jpinsonneau