Fix envtests with FlowCollector deletion #557
Conversation
|
this time, I think I've done it... damn test! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
==========================================
- Coverage 57.87% 57.80% -0.07%
==========================================
Files 73 73
Lines 9543 9563 +20
==========================================
+ Hits 5523 5528 +5
- Misses 3684 3694 +10
- Partials 336 341 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
New changes are detected. LGTM label has been removed. |
There was is timing issue with FlowCollector taking more time than the test timeout to be deleted. One option could have been to increase the timeout, but here we're simply checking that the DeletionTimestamp field is set, which means the resource has been marked for deletion. Another issue found while testing, was the eBPF agent potentially calling `status.CheckDaemonSetProgress` with a nil parameter, which triggered an error. Adding nil-checks to StatusManager functions.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was is timing issue with FlowCollector taking more time than the test timeout to be deleted. One option could have been to increase the timeout, but here we're simply checking that the DeletionTimestamp field is set, which means the resource has been marked for deletion.
Another issue found while testing, was the eBPF agent potentially calling
status.CheckDaemonSetProgresswith a nil parameter, which triggered an error. Adding nil-checks to StatusManager functions.