-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: development using "make run" (with loki) #61
Conversation
eranra
commented
Feb 17, 2022
•
edited
Loading
edited
- Updating the Makefile to allow deploy and undeploy of sample cr (there was some unneeded | etch command)
- Adding Development documentation inside hack folder
- Adding simple Loki deployment
- Adding simple Loki Grafana deployment script
d78eb82
to
4a58aab
Compare
Currently we have some hacks in https://github.com/netobserv/documents , especially for loki & grafana, so I don't think we want to have that in two different places, however maybe it makes more sense to have it in the operator repo indeed. Beside that, we haven't introduced much shell scripts yet, maybe we can keep using the makefile to add loki/grafana deploying targets? We could copy here the zero-click loki/grafana templates (https://github.com/netobserv/documents/tree/main/examples/zero-click-loki) and simply execute |
@jotak when I asked in slack and you and @stleerh provided two solutions I said to myself that we need something agreed and common for testing and experience with the operator. In flowlogs2metrics we have something that looks like https://github.com/netobserv/flowlogs2metrics/blob/main/Makefile#L128 ... it also deploys Grafana and Prometheus. Once we get the work from @OlivierCazade to deploy the dependent operator, maybe the script to deploy Loki will not be needed. As for the hacking doc ... it was very helpful to me when I did the end-to-end tests with the console and flowlogs2metrics deployed with the operator ... especially https://github.com/netobserv/network-observability-operator/pull/61/files#diff-88be51eadd2c2ccdf0a6f5bb8255bbe4f37f2b887a6839f638bc45f6cfe18bb4R12-R26 are missing and should be added somewhere. Please advise what you prefer to have here ... From my PoV ./... working with |
I like the approach you have in FL2M, it's similar to our "zero-click-loki" wired in the Makefile, I think we could have the same here. And same for grafana. Also +1 for documenting the |
Also consider this new option for quick deploy #59 |
a9a0d98
to
0fa6f1e
Compare
/lgtm @memodi @jechen0648 there's a couple of changes in the Makefile here, not sure if it impacts some test cases / doc that you wrote. Not a big change, especially if you were using |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |