Enable openshift subnets by default #619
Conversation
Enabling openshift subnets by default allows to accurately identify cluster external traffic, which is a major use case for netobserv
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
| @@ -910,7 +911,8 @@ type DebugConfig struct { | |||
| // `SubnetLabels` allows to define custom labels on subnets and IPs or to enable automatic labelling of recognized subnets in OpenShift. | |||
| type SubnetLabels struct { | |||
| // `openShiftAutoDetect` allows, when set to `true`, to detect automatically the machines, pods and services subnets based on the | |||
| // OpenShift install configuration and the Cluster Network Operator configuration. | |||
| // OpenShift install configuration and the Cluster Network Operator configuration. Indirectly, this is a way to accurately detect | |||
| // external traffic: flows that are not labeled for those subnets are external to the cluster. Enabled by default on OpenShift. | |||
There was a problem hiding this comment.
do u want to add
//+kubebuilder:default:=true
There was a problem hiding this comment.
I prefer to keep nil by default , and have default handling in code, it's more flexible and allows us to change the default values between releases
| @@ -1121,7 +1122,8 @@ type AdvancedPluginConfig struct { | |||
| // `SubnetLabels` allows to define custom labels on subnets and IPs or to enable automatic labelling of recognized subnets in OpenShift. | |||
| type SubnetLabels struct { | |||
| // `openShiftAutoDetect` allows, when set to `true`, to detect automatically the machines, pods and services subnets based on the | |||
| // OpenShift install configuration and the Cluster Network Operator configuration. | |||
| // OpenShift install configuration and the Cluster Network Operator configuration. Indirectly, this is a way to accurately detect | |||
| // external traffic: flows that are not labeled for those subnets are external to the cluster. Enabled by default on OpenShift. | |||
|
@jotak: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jotak
added
no-qe
Enabling openshift subnets by default allows to accurately identify cluster external traffic, which is a major use case for netobserv
Also add more info to CRD doc
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.