-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1613: switch kubectl apply to use server-side #634
Conversation
@msherif1234: This pull request references NETOBSERV-1613 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-operator |
1 similar comment
/test e2e-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, otherwise looks good. Thanks @msherif1234
Makefile
Outdated
@@ -459,7 +459,7 @@ catalog-push: ## Push a catalog image. | |||
# Deploy the catalog. | |||
.PHONY: catalog-deploy | |||
catalog-deploy: ## Deploy a catalog image. | |||
$(SED) -e 's~<IMAGE>~$(CATALOG_IMAGE)~' ./config/samples/catalog/catalog.yaml | kubectl apply -f - | |||
$(SED) -e 's~<IMAGE>~$(CATALOG_IMAGE)~' ./config/samples/catalog/catalog.yaml | kubectl apply --server-side -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's needed on the catalog here. Only CRD is affected by the issue
85aaf2c
to
8be60df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 66.97% 67.01% +0.03%
==========================================
Files 68 68
Lines 7783 7783
==========================================
+ Hits 5213 5216 +3
+ Misses 2194 2192 -2
+ Partials 376 375 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It more efficient than current default which client-side which embed the last applied state in metadata and as the object increase its possible to exceed APIs max object size for more detial refer to https://kubernetes.io/docs/reference/using-api/server-side-apply/#comparison-with-client-side-apply Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
It more efficient than current default which client-side which embed the last applied state in metadata and as the object increase its possible to exceed APIs max object size
for more detial refer to
https://kubernetes.io/docs/reference/using-api/server-side-apply/#comparison-with-client-side-apply
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.