Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-140: top pods talkers (and other sample updates) #645

Merged
merged 1 commit into from
May 21, 2024
Merged

NETOBSERV-140: top pods talkers (and other sample updates) #645

merged 1 commit into from
May 21, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented May 17, 2024

Description

  • Add a short description on every sample
  • Add top pods traffic, and top pods RTT
  • Add top services traffic, with ports
  • Improve service ports example to show only root ports (well, <=1029) and show the associated src/dst workloads

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak
NETOBSERV-140: top pods talkers (and other sample updates)
72f7a4a 
- Add a short description on every sample
- Add top pods traffic, and top pods RTT
- Add top services traffic, with ports
- Improve service ports example to show only root ports (well, <=1029)
  and show the associated src/dst workloads
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 17, 2024 •
edited by openshift-ci bot

@jotak: This pull request references NETOBSERV-140 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Description

  • Add a short description on every sample
  • Add top pods traffic, and top pods RTT
  • Add top services traffic, with ports
  • Improve service ports example to show only root ports (well, <=1029) and show the associated src/dst workloads

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member Author

jotak commented May 17, 2024

@memodi feel free to mark that no-qe if you want: this is only updating the metrics examples, nothing changed in the core product.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (76023fe) to head (72f7a4a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files          68       68           
  Lines        7804     7804           
=======================================
  Hits         5229     5229           
  Misses       2197     2197           
  Partials      378      378
Flag Coverage Δ
unittests 67.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@memodi
Copy link
Contributor

memodi commented May 20, 2024

@memodi feel free to mark that no-qe if you want: this is only updating the metrics examples, nothing changed in the core product.

SGTM, thanks!

/label no-qe

@openshift-ci openshift-ci bot added the no-qe This PR doesn't necessitate QE approval label May 20, 2024
OlivierCazade
OlivierCazade approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label May 21, 2024
@jotak
Copy link
Member Author

jotak commented May 21, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c2ea447 into netobserv:main May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@msherif1234 msherif1234 Awaiting requested review from msherif1234

Assignees

@OlivierCazade OlivierCazade

Labels
approved jira/valid-reference lgtm no-qe This PR doesn't necessitate QE approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jotak @openshift-ci-robot @codecov-commenter @memodi @OlivierCazade