add development_kind

[eranra]

This PR adds an end-to-end kind deployment for the operator to allow quick and efficient development of the operator locally. It deployed Kind with OVN-Kubernetes and all relevant components

[eranra]

@jotak the kind.sh is not working for me --- I am using windows WSL as my "linux machine" and I get::

eranra@ERANRAICHS-1MM6-wsl [3059] ~
$ kubectl logs ovs-node-5fvl4 -n ovn-kubernetes
================== ovnkube.sh --- version: 3 ================
 ==================== command: ovs-server
 =================== hostname: ovn-worker
 =================== daemonset version 3
 =================== Image built from ovn-kubernetes ref: refs/heads/master  commit: fc51865676fd515ebaaa7b43ebeeb139f30a4ce6
Starting ovsdb-server.
Configuring Open vSwitch system IDs.
Enabling remote OVSDB managers.
modprobe: FATAL: Module openvswitch not found in directory /lib/modules/5.10.60.1-microsoft-standard-WSL2
Inserting openvswitch module ... failed!
rmmod: ERROR: could not open '/sys/module/bridge/holders': No such file or directory
rmmod: ERROR: Module unloading is not supported
removing bridge module ... failed!

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from eranra after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

Sorry Eran, this PR has been pending for a long time...
My fear is that it could create more maintenance burden, to deal with all the various environment that the team is using , when starting something like kind.
I have some failures when I try to run it, I'd need to investigate what's going on

 ✗ Ensuring node image (kindest/node:v1.23.3) 🖼 
ERROR: failed to create cluster: failed to pull image "kindest/node:v1.23.3": command "podman pull kindest/node:v1.23.3" failed with error: exit status 125
Command Output: Error: short-name resolution enforced but cannot prompt without a TTY
make: *** [.mk/development.mk:5 : create-kind-cluster] Erreur 1

I also remember I had to do some special stuff wrt. selinux

[jotak]

After fixing the issues, I'm still getting a timeout error during control plane init :/
When I used kind previously, I was passing -wk 1 to kind.sh which used to work better with my small 16GB laptop, but now even that isn't enough (or there's another problem that doesn't show up in my logs).
Hopefully I should soon receive a better laptop :)

[eranra]

/retest

[eranra]

Hi @jotak after fighting with OVN-k8s for half a day I moved to the old get logs from simulator on kind approach. This is not 100% testing all the functionality of the operator but it does provide a lot of value ... let me know what do you think on the updated PR code.

[jotak]

Not sure exactly why the CI fails, but I can reproduce locally, if I delete my bin directory then run make build, it fails due to missing bin/controller-gen. It works on the main branch.

I guess it is related to .bingo ? By the way, could you explain to the team a little bit about bingo, why using it and what it changes for us? (I don't know if others are familiar with it, personally I'm not)

[eranra]

Not sure exactly why the CI fails, but I can reproduce locally, if I delete my bin directory then run make build, it fails due to missing bin/controller-gen. It works on the main branch.

I guess it is related to .bingo ? By the way, could you explain to the team a little bit about bingo, why using it and what it changes for us? (I don't know if others are familiar with it, personally, I'm not)

Hi @jotak it was because the list of MakeFile targets changed ... it was not because of bingo but because of the additional .mk files under the .mk folder. I changed the PROJECT_DIR variable to use firstword and not lastword so now it uses the first Makefile which is the main Makefile and now things are working as expected :-)

[jotak]

/lgtm

thanks @eranra !