WIP: NETOBSERV-1642: Ovs monitoring feature #664
Conversation
|
@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| - name: OvsMonitorMD[0] | ||
| type: string | ||
| description: OVS monitor metadata for the 1st event | ||
| cardinalityWarn: avoid |
There was a problem hiding this comment.
You should also add these into columns and filters such as:
columns:
- id: OvsMonitorMD0
name: 1st OVS metadata
tooltip: OVS monitor metadata for the 1st event
field: OvsMonitorMD[0]
filter: ovs_metadata_0
default: true
width: 5
feature: ovsMonitor
...
filters:
- id: ovs_metadata_0
name: OVS monitor metadata for the 1st event
component: text
hint: Specify a single metadata.
...
There was a problem hiding this comment.
if we want to make somether smarter that concatenate the events, it will require some code changes in the plugin
There was a problem hiding this comment.
I believe there is still a need for plugin work anyway to handle the new feature if that is accurate optimizing the above can be part of that too ? for now I will see how far this takes me
There was a problem hiding this comment.
updated both agent & operator PRs to allow single field with an array
netobserv/netobserv-ebpf-agent#286 (comment)
| LokiCRWriter = "netobserv-writer" | ||
| LokiCRBWriter = "netobserv-writer-flp" | ||
| LokiCRReader = "netobserv-reader" | ||
| MaxOvsMonitorEvents = 4 |
There was a problem hiding this comment.
I'm not sure to get the impact of this yet. What would be the advantage to get more / less events metadatas ?
There was a problem hiding this comment.
for the same flow we can have multiple events md if we wanted to trace different feature for example we wanted to trace ACL, NAT, QoS for example we will see array populated with 4 metadata strings each for one of the above features, while if we trace ACL only for example then only one event md will be populated
There was a problem hiding this comment.
ok makes sense. So are we going to expose which features to trace in the FlowCollector CR ?
If so we could adapt the console plugin config dynamically and bind each field with its proper name / type etc
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:90f3501 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-90f3501Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-90f3501
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
- Coverage 66.05% 65.78% -0.27%
==========================================
Files 70 70
Lines 8186 8222 +36
==========================================
+ Hits 5407 5409 +2
- Misses 2383 2413 +30
- Partials 396 400 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:495b735 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-495b735Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-495b735
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:32ec69e make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-32ec69eOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-32ec69e
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
@msherif1234: This pull request references NETOBSERV-1642 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:0db530b make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-0db530bOr as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-0db530b
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Description
changes to support ovs monitoring config and console bits
FC config to enable ovs monitoring fearure
Dependencies
netobserv/netobserv-ebpf-agent#286
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.