H&H: Allow using Test Console (standalone) from operator 🤘

[jotak]

Description

To be used with a standalone plugin build image such as: quay.io/jotak/network-observability-standalone-frontend:riviera2024

Set spec.consolePlugin.advanced.env.TEST_CONSOLE "true"

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.55%. Comparing base (1ac0142) to head (6536824).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   66.53%   66.55%   +0.01%     
==========================================
  Files          70       70              
  Lines        8095     8108      +13     
==========================================
+ Hits         5386     5396      +10     
- Misses       2315     2316       +1     
- Partials      394      396       +2     

Flag	Coverage Δ
unittests	66.55% <82.92%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controllers/flowcollector_controller.go	72.09% <100.00%> (-0.95%)	⬇️
pkg/helper/flowcollector.go	82.71% <100.00%> (+0.49%)	⬆️
controllers/consoleplugin/consoleplugin_objects.go	86.74% <86.95%> (-0.48%)	⬇️
...trollers/consoleplugin/consoleplugin_reconciler.go	71.64% <42.85%> (+0.42%)	⬆️

[jpinsonneau]

Looks good, just a small suggestion

[jpinsonneau]

Should we use:

Suggested change

	return env == "true"
	return strconv.ParseBool(env)

and manage errors here ?

[jotak]

I tend to prefer just checking the correct case here, because it's simpler and (this is subjective) I don't believe the error brings much value here - but I don't have stronger arguments to give :-)

[jpinsonneau]

it's more for consistency with eBPF environment variables than anything.

These allow upper case "True" for example

[jpinsonneau]

Perfect ! Thanks @jotak

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment