-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1647: Do not load loki cert when loki disabled #669
Conversation
@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 66.55% 66.60% +0.05%
==========================================
Files 70 70
Lines 8108 8115 +7
==========================================
+ Hits 5396 5405 +9
+ Misses 2316 2315 -1
+ Partials 396 395 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -208,18 +208,6 @@ func (b *builder) podTemplate(cmDigest string) *corev1.PodTemplateSpec { | |||
}) | |||
} | |||
|
|||
// ensure volumes are up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this code is not necessary but I don't want to introduce a regression so close to the release, so I'm only removing it from main
, not in the backport PR, to play safe.
Note that we discussed this already a while ago: https://github.com/netobserv/network-observability-operator/pull/477/files?diff=split&w=1#r1384571479 - I don't see why this code is duplicated, and if there's a reason I can bring it back but it should be better documented and ideally covered by a test that show-case it.
/label qe-approved (based on testing for backport PR) |
@jotak: This pull request references NETOBSERV-1647 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.