-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation from feedback #672
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
=======================================
Coverage 66.60% 66.60%
=======================================
Files 70 70
Lines 8115 8115
=======================================
Hits 5405 5405
Misses 2315 2315
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few lingering nits from peer review:
- line 540 -certFile needs period
- line 548 - name needs period
- line 557 - type needs period
- Netobserv API doc regeneration openshift/openshift-docs#76593 (comment)
- A couple places where Kerry asks about the capitalization, where I think we may need to add an "Operator": Netobserv API doc regeneration openshift/openshift-docs#76593 (comment)
given that the downstream PR was merged, I'll go ahead and merge this one |
* Update documentation from feedback * add missing period
No description provided.