Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation from feedback #672

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 7, 2024

No description provided.

@jotak jotak requested a review from skrthomas June 7, 2024 10:16
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.60%. Comparing base (bc0bcef) to head (864d36b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #672   +/-   ##
=======================================
  Coverage   66.60%   66.60%           
=======================================
  Files          70       70           
  Lines        8115     8115           
=======================================
  Hits         5405     5405           
  Misses       2315     2315           
  Partials      395      395           
Flag Coverage Δ
unittests 66.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
apis/flowmetrics/v1alpha1/flowmetric_types.go 100.00% <ø> (ø)
...s/flowcollector/v1beta1/zz_generated.conversion.go 39.27% <0.00%> (ø)
...pis/flowcollector/v1beta2/zz_generated.deepcopy.go 43.76% <0.00%> (ø)

Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few lingering nits from peer review:

@jotak
Copy link
Member Author

jotak commented Jun 11, 2024

given that the downstream PR was merged, I'll go ahead and merge this one

@jotak jotak merged commit eb3ed71 into netobserv:main Jun 11, 2024
9 of 10 checks passed
jotak added a commit that referenced this pull request Jun 17, 2024
* Update documentation from feedback

* add missing period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants