NETOBSERV-1688: relax ebpf drop alert [1.6 backport] #675
Conversation
reformulate some of the text for ebpf drop alert, and relax threshold a little bit.
|
@jotak: This pull request references NETOBSERV-1688 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
On removing test: agent-metrics-test.go did never run; it should have been named "agent_metrics_test.go" to run (_ instead of -). When renamed, it actually fails. Given how little value these tests are adding, I'm removing them rather than spending time to fix them. (they only check that the objects created names match with the expected constant) The controller integration tests cover more and are much more relevant (and they run)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #675 +/- ##
===============================================
+ Coverage 66.59% 66.77% +0.18%
===============================================
Files 70 69 -1
Lines 8110 8088 -22
===============================================
Hits 5401 5401
+ Misses 2315 2293 -22
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:87c7863 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-87c7863Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-87c7863
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/label qe-approved |
|
@jotak: This pull request references NETOBSERV-1688 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
reformulate some of the text for ebpf drop alert, and relax threshold a little bit.
backport of #674