NETOBSERV-1705: do not send zone/cluster labels config...

[jotak]

do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (d02a1ab) to head (bcd6cf2).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   66.88%   66.88%   -0.01%     
==========================================
  Files          69       70       +1     
  Lines        8093     8117      +24     
==========================================
+ Hits         5413     5429      +16     
- Misses       2288     2293       +5     
- Partials      392      395       +3     

Flag	Coverage Δ
unittests	66.88% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
controllers/consoleplugin/consoleplugin_objects.go	86.97% <100.00%> (-0.04%)	⬇️
pkg/metrics/predefined_metrics.go	100.00% <100.00%> (ø)
pkg/test/util/utils.go	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[memodi]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:203d9d5
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-203d9d5
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-203d9d5

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:203d9d5 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-203d9d5

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-203d9d5
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[memodi]

@jotak when using the operator bundle from this PR (installing using operator-sdk) and creating the flowcollector with loki disabled, I am find below failures in NOO logs and FC doesn't come up:

W0625 14:30:19.041496       1 reflector.go:547] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers.go:106: failed to list *v1alpha1.ConsolePlugin: conversion webhook for console.openshift.io/v1, Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": service "webhook" not found
E0625 14:30:19.041520       1 reflector.go:150] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers.go:106: Failed to watch *v1alpha1.ConsolePlugin: failed to list *v1alpha1.ConsolePlugin: conversion webhook for console.openshift.io/v1, Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": service "webhook" not found

It doesn't seem related to the changes in PR, but I tried multiple times and not sure what are these about?

[memodi]

here's additional info with events log from operator as it goes through installing phase after deploying flowcollector:

37s         Normal    InstallSucceeded      clusterserviceversion/netobserv-operator.v0.0.0-203d9d5               waiting for install components to report healthy
36s         Normal    InstallWaiting        clusterserviceversion/netobserv-operator.v0.0.0-203d9d5               installing: waiting for deployment netobserv-controller-manager to become ready: deployment "netobserv-controller-manager" not available: Deployment does not have minimum availability.
10m         Normal    InstallWaiting        clusterserviceversion/netobserv-operator.v0.0.0-203d9d5               Webhook install failed: conversionWebhook not ready
38s         Warning   ComponentUnhealthy    clusterserviceversion/netobserv-operator.v0.0.0-203d9d5               installing: waiting for deployment netobserv-controller-manager to become ready: deployment "netobserv-controller-manager" not available: Deployment does not have minimum availability.
37s         Normal    NeedsReinstall        clusterserviceversion/netobserv-operator.v0.0.0-203d9d5               installing: waiting for deployment netobserv-controller-manager to become ready: deployment "netobserv-controller-manager" not available: Deployment does not have minimum availability.

$ build_info.sh
OCP: 4.17.0-0.nightly-2024-06-23-145410
NetObserv operator: v0.0.0-203d9d5
Loki: 0-click-loki
eBPF-agent: main
FLP: main
ConsolePlugin: main

[jotak]

@memodi could be something wrong with the ocp nightly? The first error mentioned is related to the console operator that seems to have an issue.
I just tried on a 4.15 cluster using operator-sdk + this bundle (v0.0.0-203d9d5) and it's deployed correctly

[jotak]

we might have to check if the console team is removing the version of their CR that we use .. if that's the case, we should update it. But indeed it doesn't seem related to this PR

[memodi]

/label qe-approved

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jotak]

thanks @memodi
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment