-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1705: do not send zone/cluster labels config... #677
NETOBSERV-1705: do not send zone/cluster labels config... #677
Conversation
do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs
@jotak: This pull request references NETOBSERV-1705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 66.88% 66.88% -0.01%
==========================================
Files 69 70 +1
Lines 8093 8117 +24
==========================================
+ Hits 5413 5429 +16
- Misses 2288 2293 +5
- Partials 392 395 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:203d9d5 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-203d9d5 Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-203d9d5
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
@jotak when using the operator bundle from this PR (installing using operator-sdk) and creating the flowcollector with loki disabled, I am find below failures in NOO logs and FC doesn't come up:
It doesn't seem related to the changes in PR, but I tried multiple times and not sure what are these about? |
here's additional info with events log from operator as it goes through installing phase after deploying flowcollector:
|
@memodi could be something wrong with the ocp nightly? The first error mentioned is related to the console operator that seems to have an issue. |
we might have to check if the console team is removing the version of their CR that we use .. if that's the case, we should update it. But indeed it doesn't seem related to this PR |
/label qe-approved |
@jotak: This pull request references NETOBSERV-1705 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
thanks @memodi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs
do not send zone/cluster labels config to the console plugin when the related features are disabled. Else, the console plugin assumes that they are available, regardless of the features knobs
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.