Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force conflicts on deploy #689

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 25, 2024

with kubectl apply --server-side, sometimes we get conflict errors, such as after using the make target set-xxx-image which amends the deployment env variables. Using --force-conflicts allows to ignore such conflict, and makes the new deployment prevail.

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.05%. Comparing base (66c7a62) to head (c3d2db6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files          70       70           
  Lines        8186     8186           
=======================================
  Hits         5407     5407           
  Misses       2383     2383           
  Partials      396      396           
Flag Coverage Δ
unittests 66.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

/LGTM

@jotak
Copy link
Member Author

jotak commented Jun 27, 2024

thanks @msherif1234
/approve

Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 8bb4d67 into netobserv:main Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants