-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1734: change subnets order priority #693
Conversation
Make sure auto-detected openshift labels are appended at the end of the subnets list, so that they have lower priority. It makes it possible to override in-cluster subnets.
@jotak: This pull request references NETOBSERV-1734 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 66.15% 66.38% +0.23%
==========================================
Files 71 71
Lines 8210 8211 +1
==========================================
+ Hits 5431 5451 +20
+ Misses 2383 2365 -18
+ Partials 396 395 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ok-to-test |
New images:
They will expire after two weeks. To deploy this build: # Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:cb15190 make deploy
# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cb15190 Or as a Catalog Source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cb15190
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
/label qe-approved |
@jotak: This pull request references NETOBSERV-1734 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Verified that this fixes the OpenShift auto-detect issue described in NETOBSERV-134. If you use an internal CIDR and openShiftAutoDetect is set to true, it is now able to show your custom name and the predefined names (e.g. Pods, Services). /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks !
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Make sure auto-detected openshift labels are appended at the end of the subnets list, so that they have lower priority. It makes it possible to override in-cluster subnets.
Make sure auto-detected openshift labels are appended at the end of the subnets list, so that they have lower priority. It makes it possible to override in-cluster subnets.
Description
Make sure auto-detected openshift labels are appended at the end of the subnets list, so that they have lower priority. It makes it possible to override in-cluster subnets.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.