Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-308: fix vanilla kubernetes deployment #98

Merged
merged 1 commit into from
May 10, 2022
Merged

NETOBSERV-308: fix vanilla kubernetes deployment #98

merged 1 commit into from
May 10, 2022

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented May 9, 2022

  • Adds list and watch permissions for cluster roles, which seem to be implicit in OpenShift but required in K8s.
  • Configure securityContext with runAsUser: 0 option to force execution as root (might change when we disable privileged container and use only capabilities).
  • Extra: remove redundant Int32Ptr function (there was already a K8s utility providing it).

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from mariomac after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label May 10, 2022
@mariomac mariomac merged commit 0ac20b2 into netobserv:main May 10, 2022
@mariomac mariomac deleted the vanialla branch May 10, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants