Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isWritable method #147

Merged
merged 3 commits into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public boolean isReadable() {
* @return true if the field can be write
*/
public boolean isWritable() {
return field != null || getter != null;
return field != null || setter != null;
}

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package com.mindev.pojos;

public class AccessorTestPojo {

// Field with only setter method
private int writeOnlyField;

// Field with only getter method
private int readOnlyField;

// Field with both getter and setter methods
private int readAndWriteableField;

public void setWriteOnlyField(int writeOnlyField) {
this.writeOnlyField = writeOnlyField;
}

public int getReadOnlyField() {
return readOnlyField;
}

public int getReadAndWriteableField() {
return readAndWriteableField;
}

public void setReadAndWriteableField(int readAndWriteableField) {
this.readAndWriteableField = readAndWriteableField;
}

}
106 changes: 106 additions & 0 deletions accessors-smart/src/test/java/net/minidev/asm/AccessorTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
package net.minidev.asm;

import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.lang.reflect.Field;
import java.lang.reflect.Method;

import org.junit.jupiter.api.Test;

import com.mindev.pojos.AccessorTestPojo;

public class AccessorTest {

private static class AcceptAllFilter implements FieldFilter {

@Override
public boolean canUse(Field field) {
return true;
}

@Override
public boolean canUse(Field field, Method method) {
return true;
}

@Override
public boolean canRead(Field field) {
return true;
}

@Override
public boolean canWrite(Field field) {
return true;
}

}

private static class AcceptNoneFilter implements FieldFilter {

@Override
public boolean canUse(Field field) {
return false;
}

@Override
public boolean canUse(Field field, Method method) {
return false;
}

@Override
public boolean canRead(Field field) {
return false;
}

@Override
public boolean canWrite(Field field) {
return false;
}

}

@Test
public void testWriteOnlyField() throws NoSuchFieldException, SecurityException {

Field writeOnlyField = AccessorTestPojo.class.getDeclaredField("writeOnlyField");
Accessor accessor = new Accessor(AccessorTestPojo.class, writeOnlyField, new AcceptAllFilter());

assertTrue(accessor.isWritable());
assertFalse(accessor.isReadable());

accessor = new Accessor(AccessorTestPojo.class, writeOnlyField, new AcceptNoneFilter());
assertFalse(accessor.isWritable());
assertFalse(accessor.isReadable());

}

@Test
public void testReadOnlyField() throws NoSuchFieldException, SecurityException {

Field readOnlyField = AccessorTestPojo.class.getDeclaredField("readOnlyField");
Accessor accessor = new Accessor(AccessorTestPojo.class, readOnlyField, new AcceptAllFilter());

assertFalse(accessor.isWritable());
assertTrue(accessor.isReadable());

accessor = new Accessor(AccessorTestPojo.class, readOnlyField, new AcceptNoneFilter());
assertFalse(accessor.isWritable());
assertFalse(accessor.isReadable());
}

@Test
public void testReadAndWriteableField() throws NoSuchFieldException, SecurityException {

Field readAndWriteableField = AccessorTestPojo.class.getDeclaredField("readAndWriteableField");
Accessor accessor = new Accessor(AccessorTestPojo.class, readAndWriteableField, new AcceptAllFilter());

assertTrue(accessor.isWritable());
assertTrue(accessor.isReadable());

accessor = new Accessor(AccessorTestPojo.class, readAndWriteableField, new AcceptNoneFilter());
assertFalse(accessor.isWritable());
assertFalse(accessor.isReadable());
}

}