Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the inlined ASM dependency in smart-accessors #35

Merged
merged 1 commit into from
Nov 3, 2016

Conversation

mattnelson
Copy link
Contributor

@mattnelson mattnelson commented Oct 21, 2016

Addresses #20

Example output when shading asm and accessors-smart into the same assembly. After the changes were applied the overlapping classes error was resolved.

asm-5.1.jar, accessors-smart-1.1.jar define 25 overlapping classes:
  - org.objectweb.asm.Type
  - org.objectweb.asm.AnnotationVisitor
  - org.objectweb.asm.MethodVisitor
  - org.objectweb.asm.Attribute
  - org.objectweb.asm.MethodWriter
  - org.objectweb.asm.Handler
  - org.objectweb.asm.ByteVector
  - org.objectweb.asm.Opcodes
  - org.objectweb.asm.signature.SignatureReader
  - org.objectweb.asm.FieldVisitor
  - 15 more...

@UrielCh UrielCh changed the base branch from master to v2.3 November 3, 2016 15:45
@UrielCh UrielCh merged commit d4844f2 into netplex:v2.3 Nov 3, 2016
@mattnelson
Copy link
Contributor Author

@UrielCh Do you have a timeline of when we can expect this to be released?

@burtonator
Copy link

Please merge this and I will be every so happy!!!

@cowst
Copy link

cowst commented Dec 29, 2016

Waiting for this as well.

@burtonator
Copy link

I think it would be fair to assume that this project is dead/unmaintained.

The last commit was Nov 2015... which is 13 months ago.

@mattnelson
Copy link
Contributor Author

This PR was merged only 2 months ago, so it isn't as dead as claimed.

@UrielCh Would you be able to cut a release with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants