-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Functions.swift #45
Conversation
Fix buildServerURL to check for default port 8081
These changes need to be linted (see the CI log, you can lint from the terminal). Also, the port shouldn’t be decided like this. If there’s no port, you can make it not specify a default and the forcing to local host shouldn’t be there either. The changes look particular to your usecase, and not universal for most usecases. |
Hi, In ParseServerConfiguration the port 8081 is set as default and I didn't think touching all of that was way to go. How do I " If there’s no port, you can make it not specify a default" ? as 8081 is set as the port by this point if there's no port set in ENV. What do you think is best way to achieve this? I'll be happy to fix it to work better in a general sense. |
Adding fix from netreconlab#41 to use with Hook Triggers as well.
Just fixing some typos.
Copy fix for netreconlab#41 and apply it to ParseHookTrigger
Would love to hear your thoughts on this and maybe get it a fix in pulled. |
You have merged changes from your other branches into here, typically that can create merge conflicts. It doesn’t look the comments have been addressed from #45 (comment) |
Closing this, feel free to open another PR if you have a different fix. |
thanks for the fix! |
Fix buildServerURL to not include default port 8081 when running in localhost or 127.0.0.1