Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set default port to 8080 #57

Merged
merged 5 commits into from
Jan 13, 2024
Merged

fix: Set default port to 8080 #57

merged 5 commits into from
Jan 13, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 13, 2024

Switch default port back to vapor default, 8080. See more here: https://docs.vapor.codes/advanced/server/?h=8080#port and https://docs.vapor.codes/deploy/nginx/?h=8080#more-detail.

Hostname and port can be set via environment variables

PARSE_SERVER_SWIFT_HOST_NAME: cloud-code # Should be same name as docker service
PARSE_SERVER_SWIFT_PORT: 8081

Be sure to make any applicable changes to the docker files:

command: ["serve", "--env", "production", "--hostname", "0.0.0.0", "--port", "8081"]

EXPOSE 8081
# Start the Vapor service when the image is run, default to listening on 8081 in production environment
ENTRYPOINT ["./App"]
CMD ["serve", "--env", "production", "--hostname", "0.0.0.0", "--port", "8081"]

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8cdfa86) 38.63% compared to head (03ffe9a) 38.63%.

Files Patch % Lines
...es/ParseServerSwift/ParseServerConfiguration.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   38.63%   38.63%           
=======================================
  Files          11       11           
  Lines         955      955           
=======================================
  Hits          369      369           
  Misses        586      586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit 2f5420e into main Jan 13, 2024
3 of 5 checks passed
@cbaker6 cbaker6 deleted the cbaker6-patch-1 branch January 13, 2024 18:14
@cbaker6 cbaker6 linked an issue Jan 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forced port 8081 even when not wanted for Webhooks
1 participant