fix(editor): Do not throw an error when calculating dynamic inputs/ou…

…tputs (no-changelog) (n8n-io#8858) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
netroy · Mar 11, 2024 · a3a931b · a3a931b
1 parent 9a564af
commit a3a931b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/@n8n/nodes-langchain/nodes/agents/Agent/Agent.node.ts b/packages/@n8n/nodes-langchain/nodes/agents/Agent/Agent.node.ts
@@ -285,6 +285,7 @@ export class Agent implements INodeType {
 				name: 'hasOutputParser',
 				type: 'boolean',
 				default: false,
+				noDataExpression: true,
 				displayOptions: {
 					hide: {
 						'@version': [{ _cnd: { lte: 1.2 } }],

diff --git a/packages/@n8n/nodes-langchain/nodes/chains/ChainLLM/ChainLlm.node.ts b/packages/@n8n/nodes-langchain/nodes/chains/ChainLLM/ChainLlm.node.ts
@@ -343,6 +343,7 @@ export class ChainLlm implements INodeType {
 				name: 'hasOutputParser',
 				type: 'boolean',
 				default: false,
+				noDataExpression: true,
 				displayOptions: {
 					hide: {
 						'@version': [1, 1.1, 1.3],

diff --git a/packages/workflow/src/NodeHelpers.ts b/packages/workflow/src/NodeHelpers.ts
@@ -1104,9 +1104,8 @@ export function getNodeInputs(
 			{},
 		) || []) as ConnectionTypes[];
 	} catch (e) {
-		throw new ApplicationError('Could not calculate inputs dynamically for node', {
-			extra: { nodeName: node.name },
-		});
+		console.warn('Could not calculate inputs dynamically for node: ', node.name);
+		return [];
 	}
 }
 
@@ -1129,9 +1128,7 @@ export function getNodeOutputs(
 				{},
 			) || []) as ConnectionTypes[];
 		} catch (e) {
-			throw new ApplicationError('Could not calculate outputs dynamically for node', {
-				extra: { nodeName: node.name },
-			});
+			console.warn('Could not calculate outputs dynamically for node: ', node.name);
 		}
 	}