fix(core): Change WorkflowHistory nodes/connections columns to be json (

n8n-io#7282) Github issue / Community forum post (link here to close automatically):
netroy · Sep 28, 2023 · a80abad · a80abad
1 parent cde23a1
commit a80abad
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/...src/databases/migrations/common/1695829275184-ModifyWorkflowHistoryNodesAndConnections.ts b/...src/databases/migrations/common/1695829275184-ModifyWorkflowHistoryNodesAndConnections.ts
@@ -0,0 +1,15 @@
+import type { MigrationContext, ReversibleMigration } from '@db/types';
+
+const tableName = 'workflow_history';
+
+export class ModifyWorkflowHistoryNodesAndConnections1695829275184 implements ReversibleMigration {
+	async up({ schemaBuilder: { addColumns, dropColumns, column } }: MigrationContext) {
+		await dropColumns(tableName, ['nodes', 'connections']);
+		await addColumns(tableName, [column('nodes').json.notNull, column('connections').json.notNull]);
+	}
+
+	async down({ schemaBuilder: { dropColumns, addColumns, column } }: MigrationContext) {
+		await dropColumns(tableName, ['nodes', 'connections']);
+		await addColumns(tableName, [column('nodes').text.notNull, column('connections').text.notNull]);
+	}
+}
diff --git a/packages/cli/src/databases/migrations/mysqldb/index.ts b/packages/cli/src/databases/migrations/mysqldb/index.ts
@@ -49,6 +49,7 @@ import { CreateWorkflowHistoryTable1692967111175 } from '../common/1692967111175
 import { DisallowOrphanExecutions1693554410387 } from '../common/1693554410387-DisallowOrphanExecutions';
 import { ExecutionSoftDelete1693491613982 } from '../common/1693491613982-ExecutionSoftDelete';
 import { AddWorkflowMetadata1695128658538 } from '../common/1695128658538-AddWorkflowMetadata';
+import { ModifyWorkflowHistoryNodesAndConnections1695829275184 } from '../common/1695829275184-ModifyWorkflowHistoryNodesAndConnections';
 
 export const mysqlMigrations: Migration[] = [
 	InitialMigration1588157391238,
@@ -101,4 +102,5 @@ export const mysqlMigrations: Migration[] = [
 	DisallowOrphanExecutions1693554410387,
 	ExecutionSoftDelete1693491613982,
 	AddWorkflowMetadata1695128658538,
+	ModifyWorkflowHistoryNodesAndConnections1695829275184,
 ];
diff --git a/packages/cli/src/databases/migrations/postgresdb/index.ts b/packages/cli/src/databases/migrations/postgresdb/index.ts
@@ -48,6 +48,7 @@ import { DisallowOrphanExecutions1693554410387 } from '../common/1693554410387-D
 import { ExecutionSoftDelete1693491613982 } from '../common/1693491613982-ExecutionSoftDelete';
 import { AddWorkflowMetadata1695128658538 } from '../common/1695128658538-AddWorkflowMetadata';
 import { MigrateToTimestampTz1694091729095 } from './1694091729095-MigrateToTimestampTz';
+import { ModifyWorkflowHistoryNodesAndConnections1695829275184 } from '../common/1695829275184-ModifyWorkflowHistoryNodesAndConnections';
 
 export const postgresMigrations: Migration[] = [
 	InitialMigration1587669153312,
@@ -99,4 +100,5 @@ export const postgresMigrations: Migration[] = [
 	ExecutionSoftDelete1693491613982,
 	AddWorkflowMetadata1695128658538,
 	MigrateToTimestampTz1694091729095,
+	ModifyWorkflowHistoryNodesAndConnections1695829275184,
 ];
diff --git a/packages/cli/src/databases/migrations/sqlite/index.ts b/packages/cli/src/databases/migrations/sqlite/index.ts
@@ -46,6 +46,7 @@ import { CreateWorkflowHistoryTable1692967111175 } from '../common/1692967111175
 import { DisallowOrphanExecutions1693554410387 } from '../common/1693554410387-DisallowOrphanExecutions';
 import { ExecutionSoftDelete1693491613982 } from './1693491613982-ExecutionSoftDelete';
 import { AddWorkflowMetadata1695128658538 } from '../common/1695128658538-AddWorkflowMetadata';
+import { ModifyWorkflowHistoryNodesAndConnections1695829275184 } from '../common/1695829275184-ModifyWorkflowHistoryNodesAndConnections';
 
 const sqliteMigrations: Migration[] = [
 	InitialMigration1588102412422,
@@ -95,6 +96,7 @@ const sqliteMigrations: Migration[] = [
 	DisallowOrphanExecutions1693554410387,
 	ExecutionSoftDelete1693491613982,
 	AddWorkflowMetadata1695128658538,
+	ModifyWorkflowHistoryNodesAndConnections1695829275184,
 ];
 
 export { sqliteMigrations };