forked from n8n-io/n8n
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Changes to workflow staticData erroneously updating updatedAt (n…
- Loading branch information
Showing
2 changed files
with
77 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
packages/cli/test/integration/services/workflowStaticData.service.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import { WorkflowStaticDataService } from '@/workflows/workflowStaticData.service'; | ||
import * as testDb from '@test-integration/testDb'; | ||
import Container from 'typedi'; | ||
import { createWorkflow } from '@test-integration/db/workflows'; | ||
import { Workflow } from 'n8n-workflow'; | ||
import { mockInstance } from '@test/mocking'; | ||
import { NodeTypes } from '@/NodeTypes'; | ||
import { WorkflowRepository } from '@/databases/repositories/workflow.repository'; | ||
|
||
const nodeTypes = mockInstance(NodeTypes); | ||
let workflowStaticDataService: WorkflowStaticDataService; | ||
let workflowRepository: WorkflowRepository; | ||
|
||
beforeAll(async () => { | ||
await testDb.init(); | ||
|
||
workflowStaticDataService = Container.get(WorkflowStaticDataService); | ||
workflowRepository = Container.get(WorkflowRepository); | ||
}); | ||
|
||
afterAll(async () => { | ||
await testDb.terminate(); | ||
}); | ||
|
||
describe('WorkflowStaticDataService', () => { | ||
it('should not change workflow updatedAt when calling saveStaticData', async () => { | ||
const workflowEntityOriginal = await createWorkflow(); | ||
|
||
const workflow = new Workflow({ | ||
id: workflowEntityOriginal.id, | ||
active: false, | ||
connections: {}, | ||
nodeTypes, | ||
nodes: [], | ||
}); | ||
|
||
workflow.staticData.testValue = 1; | ||
|
||
await workflowStaticDataService.saveStaticData(workflow); | ||
|
||
const workflowEntityNew = await workflowRepository.get({ | ||
id: workflowEntityOriginal.id, | ||
}); | ||
|
||
expect(workflowEntityNew?.staticData).toEqual(workflow.staticData); | ||
expect(workflowEntityNew?.updatedAt).toEqual(workflowEntityOriginal.updatedAt); | ||
}); | ||
|
||
it('should not change workflow updatedAt when calling saveStaticDataById', async () => { | ||
const workflowEntityOriginal = await createWorkflow(); | ||
const staticData = { testValue: 1 }; | ||
|
||
await workflowStaticDataService.saveStaticDataById(workflowEntityOriginal.id, staticData); | ||
|
||
const workflowEntityNew = await workflowRepository.get({ | ||
id: workflowEntityOriginal.id, | ||
}); | ||
|
||
expect(workflowEntityNew?.staticData).toEqual(staticData); | ||
expect(workflowEntityNew?.updatedAt).toEqual(workflowEntityOriginal.updatedAt); | ||
}); | ||
}); |