fix(core): Account for non-ASCII chars in filename on binary data dow…

…nload (n8n-io#7742) https://n8nio.sentry.io/issues/4641538638
netroy · Nov 17, 2023 · b4ebb1a · b4ebb1a
1 parent abe3669
commit b4ebb1a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/packages/cli/src/controllers/binaryData.controller.ts b/packages/cli/src/controllers/binaryData.controller.ts
@@ -41,8 +41,9 @@ export class BinaryDataController {
 
 			if (mimeType) res.setHeader('Content-Type', mimeType);
 
-			if (action === 'download') {
-				res.setHeader('Content-Disposition', `attachment; filename="${fileName}"`);
+			if (action === 'download' && fileName) {
+				const encodedFilename = encodeURIComponent(fileName);
+				res.setHeader('Content-Disposition', `attachment; filename="${encodedFilename}"`);
 			}
 
 			return await this.binaryDataService.getAsStream(binaryDataId);

diff --git a/packages/cli/test/integration/binaryData.api.test.ts b/packages/cli/test/integration/binaryData.api.test.ts
@@ -87,6 +87,26 @@ describe('GET /binary-data', () => {
 		});
 	});
 
+	describe('should handle non-ASCII filename [filesystem]', () => {
+		test('on request to download', async () => {
+			const nonAsciiFileName = 'äöüß.png';
+
+			const res = await authOwnerAgent
+				.get('/binary-data')
+				.query({
+					id: fsBinaryDataId,
+					fileName: nonAsciiFileName,
+					mimeType,
+					action: 'download',
+				})
+				.expect(200);
+
+			expect(res.headers['content-disposition']).toBe(
+				`attachment; filename="${encodeURIComponent(nonAsciiFileName)}"`,
+			);
+		});
+	});
+
 	describe('should return 404 on file not found [filesystem]', () => {
 		test.each(['view', 'download'])('on request to %s', async (action) => {
 			binaryDataService.getAsStream.mockImplementation(throwFileNotFound);