fix(core): Replace throw with warning when deactivating a non-active …

…workflow (n8n-io#6969)

Replaces a throw with a warning message instead, since the failure in
question is not serious enough to warrant stopping the application.

packages/cli/src/ActiveWorkflowRunner.ts

@@ -920,8 +920,10 @@ export class ActiveWorkflowRunner implements IWebhookManager {
 		// if it's active in memory then it's a trigger
 		// so remove from list of actives workflows
 		if (this.activeWorkflows.isActive(workflowId)) {
-			await this.activeWorkflows.remove(workflowId);
-			Logger.verbose(`Successfully deactivated workflow "${workflowId}"`, { workflowId });
+			const removalSuccess = await this.activeWorkflows.remove(workflowId);
+			if (removalSuccess) {
+				Logger.verbose(`Successfully deactivated workflow "${workflowId}"`, { workflowId });
+			}
 		}
 	}
 }

packages/core/src/ActiveWorkflows.ts

@@ -197,12 +197,13 @@ export class ActiveWorkflows {
 	 *
 	 * @param {string} id The id of the workflow to deactivate
 	 */
-	async remove(id: string): Promise<void> {
+	async remove(id: string): Promise<boolean> {
 		if (!this.isActive(id)) {
 			// Workflow is currently not registered
-			throw new Error(
+			Logger.warn(
 				`The workflow with the id "${id}" is currently not active and can so not be removed`,
 			);
+			return false;
 		}
 
 		const workflowData = this.workflowData[id];
@@ -244,5 +245,7 @@ export class ActiveWorkflows {
 		}
 
 		delete this.workflowData[id];
+
+		return true;
 	}
 }