Cleanup Makefile, build out-of-source into bin/ dir

[matzf]

• Build out-of-source into bin/ directory
• Use binaries in bin/ for integration tests instead of installing
• Binary names now match names also used by the packages
• make install installs into the "correct" directory also used by go install
• update golangci-lint version (and run gomft to make lint pass)

Fixes #144
Fixes #118

---

This change is 

[FR4NK-W]

Reviewed 2 of 2 files at r1, 5 of 5 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matzf)

---

Makefile, line 5 at r1 (raw file):

DESTDIR = $(shell go env GOBIN GOPATH | eval; echo $${GOBIN:-$${GOPATH:-$${HOME}/go}/bin})

I had some trouble parsing this. Would :
DESTDIR = $(shell echo $${GOBIN:-$${GOPATH}/bin:-$${HOME}/go}/bin}) not be sufficient?
The output of go env is ignored here?

---

Makefile, line 33 at r1 (raw file):

install: all
  # Note: install everything but the examples

Nice solution

[matzf]

Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @FR4NK-W)

---

Makefile, line 5 at r1 (raw file):

Previously, FR4NK-W wrote…

DESTDIR = $(shell go env GOBIN GOPATH | eval; echo $${GOBIN:-$${GOPATH:-$${HOME}/go}/bin})

I had some trouble parsing this. Would :
DESTDIR = $(shell echo $${GOBIN:-$${GOPATH}/bin:-$${HOME}/go}/bin}) not be sufficient?
The output of go env is ignored here?

Done.
The go env also takes into account some go config files (you can eg set GOBIN in .config/go/env, for whatever reason).
I did the loading of the variables wrong though, so perhaps that's why you were confused. Now it should work and I documented it a little bit.

---

Makefile, line 33 at r1 (raw file):

Previously, FR4NK-W wrote…

Nice solution

Done.

[FR4NK-W]

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)

---

Makefile, line 43 at r3 (raw file):

./_examples/helloworld/

Why does the helloworld one need to be explicited?

[matzf]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @FR4NK-W)

---

Makefile, line 43 at r3 (raw file):

Previously, FR4NK-W wrote…

./_examples/helloworld/

Why does the helloworld one need to be explicited?

It simply does not seem to be run otherwise. IIRC, directories with _ are ignored by default, so that seems to make sense.

[FR4NK-W]

Reviewed 4 of 5 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

---

Makefile, line 43 at r3 (raw file):

Previously, matzf (Matthias Frei) wrote…

It simply does not seem to be run otherwise. IIRC, directories with _ are ignored by default, so that seems to make sense.

👍

For later reference (https://golang.org/cmd/go/):

Directory and file names that begin with "." or "_" are ignored by the go tool, as are directories named "testdata".