Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp development notes #150

Merged
merged 5 commits into from
Jul 27, 2020
Merged

Webapp development notes #150

merged 5 commits into from
Jul 27, 2020

Conversation

mwfarb
Copy link
Contributor

@mwfarb mwfarb commented May 21, 2020

  • Adding notes on how to test webapp for development.
  • Adding notes documenting webapp structure for maintenance.
  • Adding notes on potential future development.

This change is Reviewable

@mwfarb mwfarb changed the title Development notes Webapp development notes May 21, 2020
@mwfarb mwfarb marked this pull request as ready for review July 16, 2020 13:26
@mwfarb
Copy link
Contributor Author

mwfarb commented Jul 16, 2020

@mmalesev @juagargi Let me know if this will be enough for maintenance documentation.

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @mwfarb)


webapp/development.md, line 52 at r2 (raw file):

## Future Features
* **Latency Tests**: *(in development)* SCION ping and traceroute results would be listed next to available paths or overlaid on path graphs allowing easy examination of performance.
* **Name Resolution**: Integration with the SCION name resolution service (RAINS), would optionally show full AS names rather than IA numbers.

Nitpick: RAINS resolves host names, not AS names.


webapp/development.md, line 95 at r2 (raw file):

git clone -b scionlab https://github.com/netsec-ethz/scion-apps
cd scion-apps
mkdir ~/go/bin # needed for make bug

I don't think this is needed anymore; install does mkdir -p $(DESTDIR).

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mwfarb! :lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mwfarb)

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@matzf matzf merged commit 9667862 into netsec-ethz:master Jul 27, 2020
@mwfarb mwfarb deleted the dev_notes branch September 5, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants