Integration tests: write more logs, check exit code

[matzf]

Integration tests

• write both stdout and stderr to a log file
• store logs as artifact in circleci. Put logs in a common subfolder under /tmp/ to make this easier
• check process exit code to find obvious problems more easily; for now, no option to signal an expected failure, instead remove the only test that was explicitly creating failures

---

This change is 

[FR4NK-W]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)

---

_examples/helloworld/helloworld_integration_test.go, line 63 at r1 (raw file):

client_error

for now, no option to signal an expected failure, instead remove the only test that was explicitly creating failures

If you don't want to add it in this PR, I think as separate PR could add the expected exit codes to the testcases and have them checked as part of the appsWaiter. Also some apps with non-failed commands exit with non-zero exit codes.

---

pkg/integration/apps.go, line 300 at r1 (raw file):

io.TeeReader

Nice solution, makes this much more concise.

[matzf]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @FR4NK-W)

---

_examples/helloworld/helloworld_integration_test.go, line 63 at r1 (raw file):

Previously, FR4NK-W wrote…

client_error

for now, no option to signal an expected failure, instead remove the only test that was explicitly creating failures

If you don't want to add it in this PR, I think as separate PR could add the expected exit codes to the testcases and have them checked as part of the appsWaiter. Also some apps with non-failed commands exit with non-zero exit codes.

Agreed. I think it will make most sense to add this feature once we want to add a test that would make use of it.

[FR4NK-W]

Reviewable status: complete! all files reviewed, all discussions resolved