-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump scion and rains dependencies #171
Conversation
…Conn_FilterPathSlice)
Motivation: The integration test library of scionproto should not be regarded as part of the public interface. By directly integrating this functionality, scion-apps gets more self-contained and is better guarded against future changes in the integration test library of scionproto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: some previous discussion in #166.
Reviewed 17 of 17 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
… into marcfrei/scionlab_nextversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r5, 3 of 6 files at r6, 2 of 2 files at r7, 3 of 3 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marcfrei)
.circleci/config.yml, line 35 at r8 (raw file):
ubuntu-1604:202007-01
Could we use the newer image ubuntu-2004:202008-01
, aka ubuntu-2004:202010-01
?
.circleci/config.yml, line 35 at r8 (raw file): Previously, FR4NK-W wrote…
Unfortunately, the new image comes with go 1.15, which breaks topology generation. What do you think, should we install go 1.14 on ubuntu-2004:202010-01 or should we just stick with ubuntu-1604:202007-01 for the time being? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @marcfrei and @matzf)
.circleci/config.yml, line 35 at r8 (raw file):
should we just stick with ubuntu-1604:202007-01 for the time being
let's stick with the older image and do the switch later together with the change to Go 1.15+
Would have been nice though.
.circleci/config.yml, line 35 at r8 (raw file): Previously, FR4NK-W wrote…
I agree, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9.
Reviewable status: complete! all files reviewed, all discussions resolved
ubuntu-2004:202010-01 comes with Go version 1.15 whereas we currently rely on 1.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r10.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is