Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scion and rains dependencies #171

Merged
merged 52 commits into from
Dec 8, 2020
Merged

Conversation

marcfrei
Copy link
Member

@marcfrei marcfrei commented Nov 18, 2020

This change is Reviewable

Motivation: The integration test library of scionproto should not be
regarded as part of the public interface. By directly integrating this
functionality, scion-apps gets more self-contained and is better guarded
against future changes in the integration test library of scionproto.
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Note: some previous discussion in #166.

Reviewed 17 of 17 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, 1 of 1 files at r5, 3 of 6 files at r6, 2 of 2 files at r7, 3 of 3 files at r8.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marcfrei)


.circleci/config.yml, line 35 at r8 (raw file):

ubuntu-1604:202007-01

Could we use the newer image ubuntu-2004:202008-01, aka ubuntu-2004:202010-01?

@marcfrei marcfrei requested a review from FR4NK-W December 8, 2020 08:50
@marcfrei
Copy link
Member Author

marcfrei commented Dec 8, 2020


.circleci/config.yml, line 35 at r8 (raw file):

Previously, FR4NK-W wrote…
ubuntu-1604:202007-01

Could we use the newer image ubuntu-2004:202008-01, aka ubuntu-2004:202010-01?

Unfortunately, the new image comes with go 1.15, which breaks topology generation. What do you think, should we install go 1.14 on ubuntu-2004:202010-01 or should we just stick with ubuntu-1604:202007-01 for the time being?

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 20 of 21 files reviewed, 1 unresolved discussion (waiting on @marcfrei and @matzf)


.circleci/config.yml, line 35 at r8 (raw file):

should we just stick with ubuntu-1604:202007-01 for the time being

let's stick with the older image and do the switch later together with the change to Go 1.15+
Would have been nice though.

@marcfrei
Copy link
Member Author

marcfrei commented Dec 8, 2020


.circleci/config.yml, line 35 at r8 (raw file):

Previously, FR4NK-W wrote…

should we just stick with ubuntu-1604:202007-01 for the time being

let's stick with the older image and do the switch later together with the change to Go 1.15+
Would have been nice though.

I agree, thanks!

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

ubuntu-2004:202010-01 comes with Go version 1.15 whereas we currently rely on 1.14.
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r10.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@marcfrei marcfrei changed the title Updates for SCIONLab update Bump scion and rains dependencies Dec 8, 2020
@marcfrei marcfrei merged commit 8a0d048 into master Dec 8, 2020
@marcfrei marcfrei deleted the marcfrei/scionlab_nextversion branch December 8, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants