Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pan: fix pathPool query path procedure + close underlay UDPConn if QUIC session was not established successfully #259

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

JordiSubira
Copy link
Contributor

@JordiSubira JordiSubira commented Oct 4, 2024

There was a bug in the procedure for querying paths, instead of querying paths provided the pathRefreshMinInterval had passed, it did it the other way round. I made use of this PR to refactor the internal procedure. In addition, I also added closing the underlay UDPConn if QUIC session was not established successfully.

While troubleshooting the library I also realized that the library is a bit messy and it would be great to spend some effort in refactoring and simplifying it as possible. We kept postponing this, partially, because we discussed about merging scionproto/snet and the pan library.


This change is Reviewable

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is now also easier to follow what happens 👍

But I believe there is a change in behavior (in addition to the fixing of the refresh after/before expiry):
refresh(dstIA, paths) l.128 is now called on the subscribers regardless of the paths having been updated or not, and regardless of the timer.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @juagargi and @marcfrei)

Copy link
Contributor Author

@JordiSubira JordiSubira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks François, you're right, if the paths aren't fetched, it isn't necessary to call refresh on every subscriber (although it is an idempotent operation). I return a boolean flag, to indicate whether the paths are fresh, i.e., recently fetched. It isn't the most elegant solution, but in any case, I am not a big fan of how the library looks like right now and some heavy lifting is anyway necessary.

Reviewable status: 1 of 3 files reviewed, all discussions resolved / -1 of 2 LGTMs obtained / 0 of 2 approvals obtained

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @juagargi and @marcfrei)

@JordiSubira JordiSubira merged commit 3f7a7dd into netsec-ethz:master Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants