pan: fix pathPool query path procedure + close underlay UDPConn if QUIC session was not established successfully #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the procedure for querying paths, instead of querying paths provided the
pathRefreshMinInterval
had passed, it did it the other way round. I made use of this PR to refactor the internal procedure. In addition, I also added closing the underlay UDPConn if QUIC session was not established successfully.While troubleshooting the library I also realized that the library is a bit messy and it would be great to spend some effort in refactoring and simplifying it as possible. We kept postponing this, partially, because we discussed about merging scionproto/snet and the pan library.
This change is