Presenter::$onAfterSignal event #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
reviewed
Oct 18, 2022
| $signalException = null; | ||
| try { | ||
| $this->processSignal(); | ||
| } catch (Throwable $signalException) { |
There was a problem hiding this comment.
It is used to assign Throwable to $signalException
|
Seem legit. For consistency, it might be a good idea to add $onSignal too. |
dg
force-pushed
the
v3.1
branch
2 times, most recently
from
d6fabf9
to
5d1c0e3
Compare
dg
force-pushed
the
v3.1
branch
5 times, most recently
from
a6e64a8
to
7b53e9d
Compare
dg
force-pushed
the
v3.1
branch
6 times, most recently
from
79af108
to
9c31b24
Compare
dg
force-pushed
the
v3.1
branch
9 times, most recently
from
3816adb
to
b08ddd5
Compare
dg
force-pushed
the
v3.1
branch
9 times, most recently
from
94b5e36
to
32db4c2
Compare
dg
force-pushed
the
v3.1
branch
4 times, most recently
from
ae29a56
to
e5e0e3b
Compare
dg
force-pushed
the
v3.1
branch
2 times, most recently
from
bfe61e7
to
e697d90
Compare
dg
force-pushed
the
v3.1
branch
8 times, most recently
from
3e12237
to
b170b62
Compare
dg
force-pushed
the
v3.1
branch
7 times, most recently
from
855889b
to
f503641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently working on a Tracy panel which tracks submitted forms and shows errors from these forms.
This is useful for debugging manually rendered forms which don't render all form errors. e.g. datagrids
Problem is it is currently hooked via
onStartupevent. That works only for components that are created viacreateComponent*(), have all required parameters for creation available during startup and are not created manually - e.g. via$this['form'] = new Form();inaction*()method. It also changes order of code execution.Having an
onAfterSignalevent would solve all of these issues and would also allow me to handle successfully submitted forms (which throw AbortException for redirect) and other signalsCurrent (bad) solution:
If you agree on proposed solution @dg I will write some tests for it.