Generalized Route::getTargetPresenter()

[JanTvrdik]

Allow using this optimization for other IRouter implementations.

Ideas for better names of anything are welcomed.

[hrach]

static?

[JanTvrdik]

We may implement the getTargetPresenters as well it for RouteList as well.

    function getTargetPresenters()
    {
        if ($this->cachedRoutes === NULL) $this->cachedRoutes = $this->buildCache();
        return empty($this->cachedRoutes['*']) ? array_keys($this->cachedRoutes) : NULL;
    }

[mishak87]

Sorry about previous comments. Without further change in RouteList it is major BC break for multiple presenters in single route?

[JanTvrdik]

@mishak87 Sorry, I have no idea what you mean. Please rephrase. This feature should be entirely without BC break.

[mishak87]

Original: FALSE skips adding anything, NULL adds default values and string one presenter if the item is Route instance.

Change: Adds interface returning multiple routes and removes FALSE branch while also renaming method to plural.

[JanTvrdik]

I still don't know what you are talking about. Are you suggesting something? Informing me of something? Are you stating facts?

[dg]

He means that you changed getTargetPresenter -> getTargetPresenters and it's return value. But getTargetPresenter is internal method, so it is not BC break.

[JanTvrdik]

@dg Does this makes sense to you? Should I finish the implementation (e.g. write tests)?

[JanTvrdik]

ping

[JanTvrdik]

Even after more than one month I still think this is a great idea. Except for the interface name, that is terrible. cc @dg

[fprochazka]

I'm not sure about the interface name, but I like the idea. 👍

[dg]

I think that getTargetPresenters can be part of IRouter.

[JanTvrdik]

That would solve the ugly IFixedTargetPresenters name. But it would be a nasty BC break. It would actually be so large BC break that if we choose to do it, we may as well break other things (I have few ideas).

[dg]

I would prefer to avoid BC break. This method can be in interface in v2.3 commented out and checked via method_exists.

[JanTvrdik]

That seems reasonable.

[dg]

Typo in commit message: IRouter

[JanTvrdik]

Yeah and it also does not have tests so we don't know whether it actually work. And I don't feel like writing them right now.

[JanTvrdik]

Do you plan to merge this to 2.3?

[dg]

Yes, will you finish it?