-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySqlDriver driver knows about subqueries now. #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As MySQL/MariaDB clearly does support subqueries. This enables proper building of queries like... ``` $table('table_a')->where('table_a.column_one IN', $table('table_b')->select('value')) ``` ... without executing the inner query first. See https://dev.mysql.com/doc/refman/8.0/en/subqueries.html and https://mariadb.com/kb/en/subqueries/
Thanks |
dg
pushed a commit
that referenced
this pull request
Oct 15, 2020
dg
pushed a commit
that referenced
this pull request
Oct 15, 2020
dg
pushed a commit
that referenced
this pull request
Oct 25, 2020
dg
pushed a commit
that referenced
this pull request
Oct 28, 2020
dg
pushed a commit
that referenced
this pull request
Oct 28, 2020
dg
pushed a commit
that referenced
this pull request
Oct 29, 2020
dg
pushed a commit
that referenced
this pull request
Oct 29, 2020
dg
pushed a commit
that referenced
this pull request
Oct 30, 2020
dg
pushed a commit
that referenced
this pull request
Nov 6, 2020
dg
pushed a commit
that referenced
this pull request
Nov 25, 2020
dg
pushed a commit
that referenced
this pull request
Dec 21, 2020
We just found problematic case here with subqueries:
Adding limit to subquery throws error:
Mysql doc https://dev.mysql.com/doc/refman/8.0/en/subquery-restrictions.html reads:
|
I temporarily reverted it until we found a solution. |
dg
added a commit
that referenced
this pull request
Apr 22, 2021
This reverts commit e89a34a. "MySQL does not support LIMIT in subqueries for certain subquery operators" dev.mysql.com/doc/refman/8.0/en/subquery-restrictions.html
dg
added a commit
that referenced
this pull request
Apr 22, 2021
This reverts commit e89a34a. "MySQL does not support LIMIT in subqueries for certain subquery operators" dev.mysql.com/doc/refman/8.0/en/subquery-restrictions.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As MySQL/MariaDB clearly does support subqueries.
This enables proper building of queries like...
... without executing the inner query first.
See https://dev.mysql.com/doc/refman/8.0/en/subqueries.html
and https://mariadb.com/kb/en/subqueries/