Fix Invalid argument supplied for foreach() for empty aggregations #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case an aggregation returns 0 rows, the fetch returns null and foreach triggers a warning.
Use-case e.g.:
$selection->aggregation('MEDIAN(WEEKDAY(created)) OVER ()', 'MEDIAN')
dg
added a commit
that referenced
this pull request
Aug 13, 2024
dg
force-pushed
the
master
branch
8 times, most recently
from
30a51c2 to
5951b69
Compare
dg
added a commit
that referenced
this pull request
Aug 15, 2024
dg
force-pushed
the
master
branch
19 times, most recently
from
56e3ff3 to
a308588
Compare
dg
added a commit
that referenced
this pull request
Aug 17, 2024
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
force-pushed
the
master
branch
6 times, most recently
from
acaff11 to
524a655
Compare
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
force-pushed
the
master
branch
3 times, most recently
from
59cb3c7 to
8811567
Compare
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
force-pushed
the
master
branch
3 times, most recently
from
a5e0f99 to
b8d12ed
Compare
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
force-pushed
the
master
branch
2 times, most recently
from
71f30c9 to
196f63e
Compare
dg
added a commit
that referenced
this pull request
Aug 18, 2024
dg
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an aggregation returns 0 rows, the fetch returns null and foreach triggers a warning.
Use-case e.g.:
$selection->aggregation('MEDIAN(WEEKDAY(created)) OVER ()', 'MEDIAN')