-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed service causes dependency checks on every request #144
Comments
fmasa
changed the title
Changed service causes dependency checks
Changed service causes dependency checks on every request
Feb 21, 2017
Hi, could you send simple failing test please? |
dg
added a commit
that referenced
this issue
Feb 27, 2017
dg
added a commit
that referenced
this issue
Feb 27, 2017
Thank you @dg ! |
dg
added a commit
that referenced
this issue
Feb 27, 2017
Thanks :) @dg |
dg
added a commit
that referenced
this issue
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a problem with current DIC expiration check.
Cosider following config:
Let's say I change content of MyService.php from
to
(file changed, dependencies didn't)
On next request
DependencyChecker
compares modification times with meta file of generated container, which differs. Dependency hash is now calculated and matches the one in meta file, so container is considered non-expired.The problem is that meta file is not updated and hash is calculated on every request, which leads to performance overhead for large containers.
The text was updated successfully, but these errors were encountered: