-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response, IResponse: unified API (BC break) #148
Conversation
66fcaba
to
010a944
Compare
55b5376
to
45e2638
Compare
@dg Any thoughts? I think this needs to be resolved before stable 3.0 version. |
|
I always assumed this was a hack for declaring nullable parameters from pre 7.1 times. |
For PHP both declarations are identical. We can agree to change |
OK, but 398dc22 is not enough, there is still a major incompatibility: |
I understand where problem is and #147 is opened. There will certainly be much more similar issues in Nette and I'll try to fix them in the next version. |
Response
API at the moment slightly differs fromIResponse
. This PR unifies both APIs. Also, explicitly marking all nullable parameters as nullable in parameter type hint.