Mailer exception unification #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,12 @@ | |||
| <?php | |||
| /** | |||
| * @author Jan Dvořák <dvorak@spinao.cz> | |||
| * | ||
| * @author David Grudl | ||
| */ | ||
| class SmtpException extends SendFailedException |
There was a problem hiding this comment.
dědíš to naopak, tohle je špatně, SmtpException je obecnější
There was a problem hiding this comment.
Well, když teď nad tím tak přemýšlím, tak už chápu proč se to snaží udělat takhle... protože SendFailedException může pak házet i ten sendmail...
There was a problem hiding this comment.
Ale pak to nemůžeš poslat v SendMailMaileru a tím to ztrácí smysl, myslel jsem, že bych v SmtpMaileru dal taky tu vyjímku SendFailed ale bude to BC break
There was a problem hiding this comment.
tak udělej interface, něco jako
class SmtpException extends \Exception {}
class SendmailException extends \Exception {}
interface SendFailedException {}
class SmtpSendFailedException extends \Exception implements SendFailedException {}
class SendmailSendFailedException extends \Exception implements SendFailedException {}(jenom nástřel, je potřeba to domyslet)
dg
added a commit
that referenced
this pull request
Jul 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.