-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator from class #46
Comments
Actually, I am not sure if argument names are considered a part of the public API. But with PHP 8’s support for named parameters, they probably should be anyway. Edit: Looks like it is indeed the case and some projects are using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Expect::from
is nice, but it does not really work for immutable objects like the following:Version without readonly
It would be nice to have
Expect::fromClass(InvoiceItem::class)
, that would check the constructor arguments instead of the public properties likeExpect::from
does.I can try to implement this, if you think this is a good idea.
The text was updated successfully, but these errors were encountered: