CodeCoverage: better support for Xdebug 3 #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
reviewed
Dec 3, 2020
| extension_loaded('xdebug') ? self::ENGINE_XDEBUG : null, | ||
| extension_loaded('pcov') ? [self::ENGINE_PCOV, phpversion('pcov')] : null, | ||
| defined('PHPDBG_VERSION') ? [self::ENGINE_PHPDBG, PHPDBG_VERSION] : null, | ||
| extension_loaded('xdebug') ? [self::ENGINE_XDEBUG, phpversion('xdebug')] : null, |
There was a problem hiding this comment.
maybe [self::ENGINE_XDEBUG => phpversion('xdebug')]?
There was a problem hiding this comment.
i thought it would be easier xd
dg
pushed a commit
that referenced
this pull request
Dec 3, 2020
dg
pushed a commit
that referenced
this pull request
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xdebug 3 requires
xdebug.modeto includecoveragefor coverage to work, otherwise coverage-related symbols are not defined and tests fail withError: Undefined constant "Tester\CodeCoverage\XDEBUG_CC_UNUSED".Users can make it work by running tester with
-d xdebug.mode=coverage, but I thought tester could setup this automatically, so that it works out of the box as with Xdebug 2. Therefore, this PR adds version number to code coverage engine info and uses that to automatically setupcoveragemode for test processes when Xdebug >= 3.0.0 is used.