Removing useless trait Nette\StaticClass #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use trait Nette\StaticClass in RouterFactory is useless, the function is to prevent creating instance + throw exception when calling non-callable static function. This function is over management, every web developer can use static method on class the correct way without this trait.
Above that the method createRouter() itself MUST NOT be inevitably as static, we can create instance of RouterFactory, register as service @routerFactory and use standard non-static method to create Router:
But feel free to have in the Nette web-project RouterFactory with static method as before, but please remove the unnecessary trait.