Add missing GitHub Workflows to ci-pr.yml, ci-deploy.yml and ci-release.yml #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBou
force-pushed
the
android-release-workflows
branch
from
2b23912
to
a6989d5
Compare
JBou
force-pushed
the
android-release-workflows
branch
from
a6989d5
to
ad7ebc4
Compare
normanmaurer
force-pushed
the
main
branch
6 times, most recently
from
07d5051
to
06d46a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As we already support building for Android, we should also publish the artifact, so other projects can simply use it without compiling it themselves.
Modifications:
Added job to
ci-pr.ymlto build for android on PR'sAdded job to
ci-deploy.ymlto deploy snapshotsAdded job to
ci-release.ymlto deploy releasesAdded Android section to README
I also added the block
Upload Test Resultsin the windows build fromci-pr.ymltoci-build.ymlPlease have a look at the added jobs, as I couldn't test them. I used the same parameters as you used in the windows release jobs.
Result:
The released artifact for Android can be used by other projects