Declarative JPMS descriptors #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
declarative-jpms-descriptors
branch
from
03a6f48
to
be00cb2
Compare
26 tasks
|
@normanmaurer no it does not this is related to the build itself, let me check today if I can fix it, I'll get back to you |
|
@normanmaurer 5a29417 fixes it |
|
@vietj can you squash this one ? |
|
sure |
tcnative should provide declarative modules for the set of its artifacts. Modifications: - remove the automatic module name declaration (META-INF/MANIFEST entry) - use the module-info maven plugin to generate module-info descriptors in META-INF/versions/11/module-info.class - the build produces multi release jars - run twice the module-info plugin and avoid copying the generated module-info.class when building the native jar, so the default jar uses io.netty.internal.tcnative as a module name, instead of the same module name with classifier Result: tcnative provides declarative java modules.
vietj
force-pushed
the
declarative-jpms-descriptors
branch
from
5a29417
to
fa7d15b
Compare
|
@normanmaurer done |
|
@normanmaurer any news about getting a release for this one ? |
|
Will look into it |
|
@vietj will do a release tomorrow |
|
awesome thanks!
…On Thu, Aug 22, 2024 at 7:29 PM Norman Maurer ***@***.***> wrote:
@vietj <https://github.com/vietj> will do a release tomorrow
—
Reply to this email directly, view it on GitHub
<#879 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCVVXZLP2IZFIQG72LLZSYNYFAVCNFSM6AAAAABMFFUA3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGI4DKNJXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcnative should provide declarative modules for the set of its artifacts.
This is a preliminary contribution that will enable the support of declarative JPMS descriptors for Netty 4.2 branch.
Generated artifacts are multi release jar to remain compatible with Java 8.
This has been tested with
netty-tcnative-openssl-staticon my arm64 mac with a jlink generated image.