Cleanup HTTP/2 tests for Http2FrameCodec and Http2MultiplexCodec #8646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested review from
bryce-anderson,
carl-mastrangelo,
trustin and
ejona86
normanmaurer
force-pushed
the
http2_test_cleanup
branch
3 times, most recently
from
a359f72 to
5893d4e
Compare
|
Looks like you're still iterating on this. Please feel free to ping me when you want it reviewed. |
normanmaurer
force-pushed
the
http2_test_cleanup
branch
from
5893d4e to
83d6e63
Compare
|
@bryce-anderson now... forgot to commit a change. |
normanmaurer
force-pushed
the
http2_test_cleanup
branch
from
83d6e63 to
86b0507
Compare
Motiviation: Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone. Modification: - Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation). Result: Easier to write tests for the codecs in the future and more robust testing in general. Beside this it also fixes #6036.
normanmaurer
force-pushed
the
http2_test_cleanup
branch
from
86b0507 to
09fe6b0
Compare
bryce-anderson
approved these changes
Dec 11, 2018
| @@ -415,27 +415,11 @@ final void onChannelReadComplete(ChannelHandlerContext ctx) { | |||
| } | |||
|
|
|||
| // Allow to override for testing | |||
There was a problem hiding this comment.
This comment is no longer true.
|
@bryce-anderson thanks fore the review.. I also addressed your comment (good catch). |
normanmaurer
added a commit
that referenced
this pull request
Dec 14, 2018
Motiviation: Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone. Modification: - Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation). Result: Easier to write tests for the codecs in the future and more robust testing in general. Beside this it also fixes #6036.
normanmaurer
added a commit
that referenced
this pull request
Dec 28, 2018
Motiviation: Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone. Modification: - Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation). Result: Easier to write tests for the codecs in the future and more robust testing in general. Beside this it also fixes #6036.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motiviation:
Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone.
Modification:
Result:
Easier to write tests for the codecs in the future and more robust testing in general.
Beside this it also fixes #6036.