Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-detect system architecture using uname -m instead of manual input. #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Auto-detect system architecture using uname -m instead of manual input. #33

wants to merge 1 commit into from

Conversation

Brandon-Roff
Copy link

for issue #30

netvolt
netvolt requested changes Feb 9, 2025
View reviewed changes
Copy link
Owner

@netvolt netvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automation of system architeture is a pretty nice improvement, but need to be included with the readme.md changes updates in order to users to be able to understand what they need to type manually.
Are you able to update it as well?

@2br-2b
Copy link
Contributor

2br-2b commented Feb 9, 2025

One other thing to note - this is a breaking change. Should we update the script to handle people who pass the architecture as well, or use releases to tag specific versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netvolt netvolt netvolt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brandon-Roff @2br-2b @netvolt