Issue 26 #37
Issue 26 #37
Conversation
merging last changes
|
@stevehu could you release this? |
| } | ||
|
|
||
| private boolean isRelativePath(String schemaUrl) { | ||
| return !schemaUrl.startsWith("http"); |
There was a problem hiding this comment.
What about relative local paths? With this change I can't load local schemas anymore using $ref.
| } | ||
|
|
||
| private String obtainAbsolutePath(JsonSchema parentSchema, String schemaUrl) { | ||
| String baseSchemaUrl = parentSchema.findAncestor().getSchemaNode().get("id").textValue(); |
There was a problem hiding this comment.
Where does this "id" property come from and why is it treated as a URL?
There was a problem hiding this comment.
I found https://spacetelescope.github.io/understanding-json-schema/structuring.html?highlight=dependencies#the-id-property. But it should be optional, I'd say. I still want to use $ref on local relative files.
|
@whiskeysierra I hear you. There are too many version of specs and it is very hard to support all of them at the same time with the current architecture. I am planning to refactor it with service from light-4j so that different user can choose their implementations. |
adding relative $ref urls