fix/#407 the value in values.yml can be set to empty #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiachen1120
requested review from
stevehu,
DSchrupert,
ddobrin and
GavinChenYan
ddobrin
requested changes
Feb 26, 2019
There was a problem hiding this comment.
Could I maybe suggest that we do not use a static variable for transferring data between methods?
The snippet:
...
// Throw exception when no parsing result found
if (value == null && !fileContainsKey) {
throw new ConfigException(
""${" + m.group(1) + "}" appears in config file cannot be expanded");
// Return directly when the parsing result don't need to be casted to String
...
can actually be moved into the getValue() method, if you wish to do so, and ascertain both the null value and the fileContainsKey boolean.
How does this sound?
…ariable for transferring data - added test case
|
@ddobrin Sounds great! 👍Thanks! I already changed to what you suggested. Also, a test case is added to test null value scenario. |
ddobrin
approved these changes
Feb 27, 2019
DSchrupert
approved these changes
Feb 28, 2019
younggwon1
pushed a commit
to younggwon1/light-4j
that referenced
this pull request
Feb 10, 2024
…knt#409) * fix/networknt#407 the value in values.yml can be set to empty * - moved some code block into the getValue() to prevent using static variable for transferring data - added test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #407