Add an option to expose Prometheus metrics via http/s in the forwarder-vpp #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszirtes
force-pushed
the
prometheus-without-otel
branch
from
c2a864c
to
cae240c
Compare
main.go
Outdated
Comment on lines
156
to
164
| collectorAddress := cfg.OpenTelemetryEndpoint | ||
| spanExporter := opentelemetry.InitSpanExporter(ctx, collectorAddress) | ||
| metricExporter := opentelemetry.InitPrometheusMetricExporter(ctx) | ||
| o := opentelemetry.Init(ctx, spanExporter, metricExporter, cfg.Name) | ||
| defer func() { | ||
| if err = o.Close(); err != nil { | ||
| log.FromContext(ctx).Error(err.Error()) | ||
| } | ||
| }() |
There was a problem hiding this comment.
Curious. Why do we need to use opentemeltry in the prometheus branch?
bszirtes
force-pushed
the
prometheus-without-otel
branch
2 times, most recently
from
b95ca3a
to
e24ec63
Compare
|
Could you please rebase the branch to the latest sdk? |
bszirtes
force-pushed
the
prometheus-without-otel
branch
6 times, most recently
from
55cc797
to
402950b
Compare
|
Hi @denis-tingaikin, I have rebased the branch to the latest sdk. |
internal/config/config.go
Outdated
Comment on lines
52
to
53
| PrometheusIP string `default:"" desc:"Prometheus IP address" split_words:"true"` | ||
| PrometheusPort uint16 `default:"8081" desc:"Prometheus port to use" split_words:"true"` |
There was a problem hiding this comment.
Can be combined to PrometheusListenOn by analogy with ListenOn, PprofListenOn.
bszirtes
force-pushed
the
prometheus-without-otel
branch
from
402950b
to
e387185
Compare
…r-vpp Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
bszirtes
force-pushed
the
prometheus-without-otel
branch
from
e387185
to
cdc9953
Compare
|
Hi @denis-tingaikin, Thanks! I've made the modification as you recommended. |
denis-tingaikin
approved these changes
Aug 27, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Aug 27, 2024
…d-forwarder-vpp@main PR link: networkservicemesh/cmd-forwarder-vpp#1137 Commit: bed7f0f Author: Botond Szirtes Date: 2024-08-27 14:14:23 +0200 Message: - Add an option to expose Prometheus metrics via http/s in the forwarder-vpp (#1137) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Aug 27, 2024
…d-forwarder-vpp@main (#12270) PR link: networkservicemesh/cmd-forwarder-vpp#1137 Commit: bed7f0f Author: Botond Szirtes Date: 2024-08-27 14:14:23 +0200 Message: - Add an option to expose Prometheus metrics via http/s in the forwarder-vpp (#1137) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a section in the main for initializing Prometheus and extended the config with the required variables.
Issue link
networkservicemesh/sdk#1652
How Has This Been Tested?
Types of changes