fix: internal nsc should correctly work with dns #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
edwarnicke
reviewed
May 26, 2022
denis-tingaikin
changed the title
denis-tingaikin
force-pushed
the
fix-dns-issue
branch
from
2c635da to
c6eeb74
Compare
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-dns-issue
branch
from
3092322 to
584395f
Compare
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 26, 2022
…d-nsc@main PR link: networkservicemesh/cmd-nsc#443 Commit: c2cd55e Author: Denis Tingaikin Date: 2022-05-26 17:41:38 +0300 Message: - fix: internal nsc should correctly work with dns (#443) * external nsc should correctly work with dns Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin denis.tingajkin@xored.com
Motivation
Fixes unstable TestMutually_aware_nses test