Add strictipam.Server to cleanup ipcontext on healing
#677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
approved these changes
May 27, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 27, 2024
…d-nse-icmp-responder-vpp@main PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#677 Commit: 1406d90 Author: Denis Tingaikin Date: 2024-05-27 13:30:55 +0300 Message: - Merge pull request #677 from NikitaSkrynnik/strictipam Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 27, 2024
…d-nse-icmp-responder-vpp@main (#12034) PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#677 Commit: 1406d90 Author: Denis Tingaikin Date: 2024-05-27 13:30:55 +0300 Message: - Merge pull request #677 from NikitaSkrynnik/strictipam Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…k-vpp@main PR link: networkservicemesh/sdk-vpp#847 Commit: a7b2adb Author: Network Service Mesh Bot Date: 2024-08-20 04:08:04 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#847) PR link: networkservicemesh/sdk-kernel#677 Commit: 573b7f2 Author: Network Service Mesh Bot Date: 2024-08-20 04:03:42 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#677) PR link: networkservicemesh/sdk#1656 Commit: 6fad31a Author: Nikita Skrynnik Date: 2024-08-20 20:00:35 +1100 Message: - Use a context with exteded timeout on Requests in begin (#1656) * Use an extended timeout in case of reselect requests * add unit test * fix race condition * use a context with exteded timeout on Requests in begin * fix unit tests * fix race conditions in dial * fix variable name * fix go linter issues --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
that referenced
this pull request
Aug 20, 2024
…k-vpp@main (#693) PR link: networkservicemesh/sdk-vpp#847 Commit: a7b2adb Author: Network Service Mesh Bot Date: 2024-08-20 04:08:04 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#847) PR link: networkservicemesh/sdk-kernel#677 Commit: 573b7f2 Author: Network Service Mesh Bot Date: 2024-08-20 04:03:42 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#677) PR link: networkservicemesh/sdk#1656 Commit: 6fad31a Author: Nikita Skrynnik Date: 2024-08-20 20:00:35 +1100 Message: - Use a context with exteded timeout on Requests in begin (#1656) * Use an extended timeout in case of reselect requests * add unit test * fix race condition * use a context with exteded timeout on Requests in begin * fix unit tests * fix race conditions in dial * fix variable name * fix go linter issues --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
strictipam.Serverto clean upipcontextin the request to prevent infinite healing. It happens because of additional ip addresses inipcontextafter the first healing.Issue
Closes networkservicemesh/deployments-k8s#12033