Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from update/networkservicemesh/sdk #385

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

nsmbot
Copy link
Contributor

@nsmbot nsmbot commented Oct 13, 2021

Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1083
Commit: e4c4722
Author: Ed Warnicke
Date: 2021-10-13 16:51:05 -0500
Message:

  • Rework client, connect, to simplify and prepare for simpler healing. (# 1083)
  • Rework client, connect, to simplify and prepare for simpler healing.
    Previously we had a single 'client' per grpc.ClientConnInterface.
    This created a lot of complexity, particularly in connect.
    This rework of client moves to a single 'client' that can handle
    multiple grpc.ClientConnInterfaces.
    This vastly simplified both the client chain and connect chain.
    Finally, heal has been temporarily removed in preparation for a rework
    of heal focused on back propogating Connection 'DOWN' events via
    monitor. The net net at the end of the process should be:
  1. Refresh is only originated by actual clients, not the 'client' part
    of passthrough NSEs
  2. Heal will only be originated by actual clients, not the 'client' part
    pf passthrough NSEs.
    Signed-off-by: Ed Warnicke hagbard@gmail.com

…k@main

PR link: networkservicemesh/sdk#1083

Commit: e4c4722
Author: Ed Warnicke
Date: 2021-10-13 16:51:05 -0500
Message:
  - Rework client, connect, to simplify and prepare for simpler healing. (#1083)
* Rework client, connect, to simplify and prepare for simpler healing.

Previously we had a single 'client' per grpc.ClientConnInterface.
This created a lot of complexity, particularly in connect.

This rework of client moves to a single 'client' that can handle
multiple grpc.ClientConnInterfaces.

This vastly simplified both the client chain and connect chain.

Finally, heal has been temporarily removed in preparation for a rework
of heal focused on back propogating Connection 'DOWN' events via
monitor.  The net net at the end of the process should be:

1)  Refresh is only originated by actual clients, not the 'client' part
of passthrough NSEs
2)  Heal will only be originated by actual clients, not the 'client' part
pf passthrough NSEs.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

and also networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Switch to dial per request

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Rebased and adapted to testing.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comments.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Fix golangci-lint errors.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Fix to test goroutine leak checking.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Fix improper go routine leak checks in tests.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Rework dial chain element to handle cleanup on close correctly.

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Restored grpc.WaitForReady in sandbox

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment https://github.com/networkservicemesh/sdk/pull/1083/files/4451e69ec246e30dde13a60d9f86efeb8a680766#r719022909

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment https://github.com/networkservicemesh/sdk/pull/1083/files/4451e69ec246e30dde13a60d9f86efeb8a680766#r719023399

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Introducing monitor client chain element

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to comment networkservicemesh/sdk#1083 (comment)

Signed-off-by: Ed Warnicke <hagbard@gmail.com>

* Response to networkservicemesh/sdk#1083 (comment)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@github-actions github-actions bot merged commit cc960ad into main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant